Drupal Code Review Procedure
Basic requirements
- There should be NO custom coding to Drupal Core or to any contributed components (modules, themes, libraries).
- Modifications to contributed modules or themes should be implemented as custom modules or subthemes.
- Disable, uninstall, and remove all contributed modules, libraries, and themes NOT IN USE.
- Documentation (README.txt) for custom modules is required.
- Custom modules reside in a sites/all/modules/custom folder.
- Custom themes (subthemes and contributed base themes) reside in a sites/all/themes folder.
- Remove any debugging and/or commented out code.
- Remove development modules.
- Remove any source and version control files and folders (ie. .svn .dstore)
- Stable releases of any contributed modules are preferred; flag any dev versions and provide explanation for why it was included.
- Do not use the Features module in your application. We do not support Features because it interferes with our Drupal update process. Our developers are happy to discuss alternatives to using the Features module in your application.
Vendor deliverables
- Output of phpinfo command run at vendor site.
- List of all modules and libraries in use.
- Documentation on any customized components
- Include README.txt for custom modules
- This documentation should include at a minimum the purpose of the module and installation instructions.
- A single tarball of entire site (core and all)
- sites/all/modules/customfolder should include all custom modules
- sites/all/themesfolder should include all custom subthemes and contributed base themes
- The site should include a database folder containing the output of the mysql database unload.
- The site should include a documentation folder containing the phpinfo command output.
- Any version control files (.svn etc) should be excluded.
Internal review process
- Deploy supplied site in our development virtual environment.
- Examine phpinfo output for conflicts with Dev environment.
- Review that the supplied list of modules is accurate.
- Verify custom modules and themes are in proper folders (sites/all/modules/custom sites/all/themes)
- Check for modules in need of updating.
- Check for disabled modules.
- Verify release levels of any contributed modules.
- Install and run 'Hacked' which checks whether core or contributed modules have been modified.
- Install and run 'Coder' which checks for compliance with Drupal coding standards.
- Examine README.txt supplied with custom modules.
If you wish to discuss a Service Level Agreement, contact ops-help.